Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:47356 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbcIBQJW (ORCPT ); Fri, 2 Sep 2016 12:09:22 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [v2] ath9k: mark ath_fill_led_pin() static From: Kalle Valo In-Reply-To: <1472473273-2972-1-git-send-email-baoyou.xie@linaro.org> To: Baoyou Xie CC: , , , , , , , , Message-ID: <7db487f5a15c4563a92de6da26a633fd@euamsexm01a.eu.qualcomm.com> (sfid-20160902_180943_132905_29D5AD65) Date: Fri, 2 Sep 2016 18:09:12 +0200 Sender: linux-wireless-owner@vger.kernel.org List-ID: Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the ath9k gpio driver when building with W=1: > drivers/net/wireless/ath/ath9k/gpio.c:25:6: warning: no previous prototype for 'ath_fill_led_pin' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie Thanks, 1 patch applied to ath-next branch of ath.git: c39265f72ae6 ath9k: mark ath_fill_led_pin() static -- Sent by pwcli https://patchwork.kernel.org/patch/9303795/