Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56863 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbcIHRfS (ORCPT ); Thu, 8 Sep 2016 13:35:18 -0400 From: Kalle Valo To: Bjorn Andersson Cc: Eugene Krasnikov , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev , lkml , Andy Gross , linux-arm-msm Subject: Re: [PATCH v4 2/4] wcn36xx: Transition driver to SMD client References: <1473200312-22438-1-git-send-email-bjorn.andersson@linaro.org> <1473200312-22438-2-git-send-email-bjorn.andersson@linaro.org> <87k2emsi22.fsf@kamboji.qca.qualcomm.com> Date: Thu, 08 Sep 2016 20:35:11 +0300 In-Reply-To: (Bjorn Andersson's message of "Thu, 8 Sep 2016 08:31:36 -0700") Message-ID: <878tv2s3ao.fsf@kamboji.qca.qualcomm.com> (sfid-20160908_193538_973172_F0BDB1D5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Bjorn Andersson writes: > On Thu, Sep 8, 2016 at 5:16 AM, Kalle Valo wrote: >> Bjorn Andersson writes: >> >>> The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD >>> channel, as such it should be a SMD client. This patch makes this >>> transition, now that we have the necessary frameworks available. >>> >>> Signed-off-by: Bjorn Andersson >>> --- >>> >>> Changes since v3: >>> - Made msg_header const in wcn36xx_smd_rsp_process() >>> >>> Changes since v2: >>> - Correct the call to the new ieee80211_scan_completed() >>> >>> drivers/net/wireless/ath/wcn36xx/dxe.c | 16 +++--- >>> drivers/net/wireless/ath/wcn36xx/main.c | 79 ++++++++++++++++++++---------- >>> drivers/net/wireless/ath/wcn36xx/smd.c | 31 +++++------- >>> drivers/net/wireless/ath/wcn36xx/smd.h | 5 ++ >>> drivers/net/wireless/ath/wcn36xx/wcn36xx.h | 21 +++----- >>> 5 files changed, 86 insertions(+), 66 deletions(-) >> >> This doesn't compile for me: >> > > I thought I mentioned this in the mail, sorry for missing that. Maybe you did and I just forgot, I have a tendency to do that :) > There is a patch for this issue in linux-next already [1] which is > part of [2], which was part of the pull request to arm-soc for > inclusion in v4.9. > > [1] https://patchwork.kernel.org/patch/9272457/ > [2] https://git.kernel.org/cgit/linux/kernel/git/agross/linux.git/tag/?h=qcom-drivers-for-4.9 So the commit in question is: soc: qcom: smd: Correct compile stub prototypes https://git.kernel.org/cgit/linux/kernel/git/agross/linux.git/commit/?h=qcom-drivers-for-4.9&id=3a1281848830fcb3202cfd7ffe62d19641471d05 But that's not obviously in my tree yet, but I should have it after 4.9-rc1 is released. I think it's easiest that I wait for that before applying these. Do you agree? -- Kalle Valo