Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:24963 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753471AbcICRfj (ORCPT ); Sat, 3 Sep 2016 13:35:39 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: ath9k: bring back direction setting in ath9k_{start_stop} From: Kalle Valo In-Reply-To: <20160901174702.8645-1-giedrius.statkevicius@gmail.com> To: Giedrius Statkevi?ius CC: , , , , , , Miaoqing Pan , , =?UTF-8?q?Giedrius=20Statkevi=C4=8Dius?= Message-ID: (sfid-20160903_193600_481089_9DB13D77) Date: Sat, 3 Sep 2016 19:35:29 +0200 Sender: linux-wireless-owner@vger.kernel.org List-ID: Giedrius Statkevi?ius wrote: > A regression was introduced in commit id 79d4db1214a ("ath9k: cleanup > led_pin initial") that broken the WLAN status led on my laptop with > AR9287 after suspending and resuming. > > Steps to reproduce: > * Suspend (laptop) > * Resume (laptop) > * Observe that the WLAN led no longer turns ON/OFF depending on the > status and is always red > > Even though for my case it only needs to be set to OUT in ath9k_start > but for consistency bring back the IN direction setting as well. > > Cc: Miaoqing Pan > Cc: Kalle Valo > Cc: > Signed-off-by: Giedrius Statkevičius I'm planning to queue this to 4.8 if no objections. -- Sent by pwcli https://patchwork.kernel.org/patch/9309829/