Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:59330 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163AbcICKha (ORCPT ); Sat, 3 Sep 2016 06:37:30 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of() From: Kalle Valo In-Reply-To: <1471529868-13669-1-git-send-email-javier@osg.samsung.com> To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Javier Martinez Canillas , Amitkumar Karwar , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Nishant Sarmukadam Message-Id: <20160903103520.3E62B62019@smtp.codeaurora.org> (sfid-20160903_123747_801392_F2AD56B9) Date: Sat, 3 Sep 2016 10:35:20 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. > > Signed-off-by: Javier Martinez Canillas What's the conclusion with this patch? Should I drop it or take it? (The discussion is available from the patchwork link in the signature.) -- Sent by pwcli https://patchwork.kernel.org/patch/9288169/