Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43212 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932674AbcI0PsT (ORCPT ); Tue, 27 Sep 2016 11:48:19 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [V2, 4.9] brcmfmac: use correct skb freeing helper when deleting flowring From: Kalle Valo In-Reply-To: <20160927121104.5771-1-zajec5@gmail.com> References: <20160927121104.5771-1-zajec5@gmail.com> To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Message-Id: <20160927154819.309F561405@smtp.codeaurora.org> (sfid-20160927_174856_058362_BCF4C22F) Date: Tue, 27 Sep 2016 15:48:19 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting for transmission that were passed to us > by netif. It means we checked every one of them looking for 802.1x > Ethernet type. When deleting flowring we have to use freeing function > that will check for 802.1x type as well. > > Freeing skbs without a proper check was leading to counter not being > properly decreased. This was triggering a WARNING every time > brcmf_netdev_wait_pend8021x was called. > > Signed-off-by: Rafał Miłecki > Acked-by: Arend van Spriel > Cc: stable@vger.kernel.org # 4.5+ Patch applied to wireless-drivers-next.git, thanks. 7f00ee2bbc63 brcmfmac: use correct skb freeing helper when deleting flowring -- https://patchwork.kernel.org/patch/9351797/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches