Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:51361 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755474AbcIRKOw (ORCPT ); Sun, 18 Sep 2016 06:14:52 -0400 Date: Sun, 18 Sep 2016 12:14:55 +0200 From: Greg KH To: Kalle Valo Cc: Christian Lamparter , Christian Lamparter , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, Nicolai Stange , Ben Greear , Larry Finger Subject: Re: [PATCH 2/4] carl9170: fix debugfs crashes Message-ID: <20160918101455.GA8410@kroah.com> (sfid-20160918_121520_018925_AA659B35) References: <48411543620969bebb37a1a9ea7b8f451cdfdd31.1474140477.git.chunkeey@gmail.com> <20160917214539.GA28379@kroah.com> <87d1k17idx.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <87d1k17idx.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote: > Greg KH writes: > > > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote: > >> Ben Greear reported: > >> > I see lots of instability as soon as I load up the carl9710 NIC. > >> > My application is going to be poking at it's debugfs files... > >> > > >> > BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0 > >> > [carl9170] at addr ffff8801bc1208b0 > >> > Read of size 8 by task btserver/5888 > >> > ======================================================================= > >> > BUG kmalloc-256 (Tainted: G W ): kasan: bad access detected > >> > ----------------------------------------------------------------------- > >> > > >> > INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772 > >> >... > >> > >> This breakage was caused by the introduction of intermediate > >> fops in debugfs by commit 9fd4dcece43a > >> ("debugfs: prevent access to possibly dead file_operations at file open") > > > > Because of this, these should all be backported to 4.7-stable, and > > 4.8-stable, right? > > Via which tree should these go, Greg's or mine? I'll take it if you ack it, as it's a debugfs issue. thanks, greg k-h