Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:37066 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752819AbcIOPLe (ORCPT ); Thu, 15 Sep 2016 11:11:34 -0400 Subject: Re: [PATCH v2 10/21] ath10k: support logging ath10k_info as KERN_DEBUG To: "Valo, Kalle" References: <1462986153-16318-1-git-send-email-greearb@candelatech.com> <1462986153-16318-11-git-send-email-greearb@candelatech.com> <87k2eeef79.fsf@kamboji.qca.qualcomm.com> <57D9696B.10103@candelatech.com> <87fup1b6ao.fsf@kamboji.qca.qualcomm.com> Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" From: Ben Greear Message-ID: (sfid-20160915_171136_865823_0C0FB921) Date: Thu, 15 Sep 2016 08:11:33 -0700 MIME-Version: 1.0 In-Reply-To: <87fup1b6ao.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 09/15/2016 07:12 AM, Valo, Kalle wrote: > Ben Greear writes: > >> On 09/14/2016 07:19 AM, Valo, Kalle wrote: >>> greearb@candelatech.com writes: >>> >>>> From: Ben Greear >>>> >>>> Helps keep messages off of (serial) console when >>>> that is desired. >>>> >>>> Signed-off-by: Ben Greear >>> >>> Isn't /proc/sys/kernel/print exactly for this purpose? At least I recall >>> using it. >> >> I just wanted to hide some ath10k logs from the console, not all >> system logs. I don't think that /proc/sys/kernel/print has any >> granularity? > > It should be based on KERN_ log levels. I don't know what your kernel > does, but ath10k should be printing only very few messages with level > KERN_INFO or above, all of of the debug messages. So you should be > easily able to filter out all ath10k debug messages as they are sent > with KERN_DEBUG. I originally added this when I was testing .11r associating timing. Just having a few lines of ath10k printk on the serial console added several 10s of milliseconds to the time it took to associate, and that was throwing off my results. I still wanted to see the messges in 'dmesg', just not on the console. I did not want to hide other WARN level logs from the console, just the ath10k ones. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com