Return-path: Received: from mout.kundenserver.de ([212.227.126.134]:61042 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932448AbcIEP0E (ORCPT ); Mon, 5 Sep 2016 11:26:04 -0400 From: Arnd Bergmann To: Kalle Valo Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2] bcma: use of_dma_configure() to set initial dma mask Date: Mon, 05 Sep 2016 17:26:27 +0200 Message-ID: <6123998.NAlOfyAp5F@wuerfel> (sfid-20160905_172607_770781_056D1088) In-Reply-To: <20160903140819.245F06216C@smtp.codeaurora.org> References: <20160903140819.245F06216C@smtp.codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote: > Arnd Bergmann wrote: > > While fixing another bug, I noticed that bcma manually sets up > > a dma_mask pointer for its child devices. We have a generic > > helper for that now, which should be able to cope better with > > any variations that might be needed to deal with cache coherency, > > unusual DMA address offsets, iommus, or limited DMA masks, none > > of which are currently handled here. > > > > This changes the core to use the of_dma_configure(), like > > we do for platform devices that are probed directly from > > DT. > > > > Signed-off-by: Arnd Bergmann > > Nobody tested this, so I'll drop the patch. > Should I resend it? I think it's still required. Arnd