Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:29825 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbcJLFLb (ORCPT ); Wed, 12 Oct 2016 01:11:31 -0400 From: "Valo, Kalle" To: "Kolli, Anilkumar" CC: "ath10k@lists.infradead.org" , "akolli@codeaurora.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 1/2] ath10k: add per peer htt tx stats support for 10.4 Date: Wed, 12 Oct 2016 04:59:07 +0000 Message-ID: <87vawygo2w.fsf@kamboji.qca.qualcomm.com> (sfid-20161012_072006_930438_92F68911) References: <1475852332-18217-1-git-send-email-akolli@qti.qualcomm.com> <1475852332-18217-2-git-send-email-akolli@qti.qualcomm.com> In-Reply-To: <1475852332-18217-2-git-send-email-akolli@qti.qualcomm.com> (akolli@qti.qualcomm.com's message of "Fri, 7 Oct 2016 20:28:51 +0530") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: writes: > From: Anilkumar Kolli > > Per peer tx stats are part of 'HTT_10_4_T2H_MSG_TYPE_PEER_STATS' > event, Firmware sends one HTT event for every four PPDUs. > HTT payload has success pkts/bytes, failed pkts/bytes, retry > pkts/bytes and rate info per ppdu. > Peer stats are enabled through 'WMI_SERVICE_PEER_STATS', > which are nowadays enabled by default. > > Parse peer stats and update the tx rate information per STA. > > tx rate, Peer stats are tested on QCA4019 with Firmware version > 10.4-3.2.1-00028. > > Signed-off-by: Anilkumar Kolli This and patch 2 add few new warnings: drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_fetch_pee= r_stats': drivers/net/wireless/ath/ath10k/htt_rx.c:2279:3: warning: too many argument= s for format [-Wformat-extra-args] drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: warning: incorrect type i= n assignment (different base types) drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: expected unsigned int = [unsigned] [usertype] peer_id drivers/net/wireless/ath/ath10k/htt_rx.c:2285:17: got restricted __le16 = [usertype] peer_id drivers/net/wireless/ath/ath10k/debugfs_sta.c:84: space required before the= open parenthesis '(' --=20 Kalle Valo=