Return-path: Received: from mail-yb0-f195.google.com ([209.85.213.195]:33525 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbcJKO1h (ORCPT ); Tue, 11 Oct 2016 10:27:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <20161010071943.4717-1-chris@rorvick.com> <1476108164.5210.11.camel@coelho.fi> <1476180668.17022.21.camel@tiscali.nl> From: Chris Rorvick Date: Tue, 11 Oct 2016 09:27:36 -0500 Message-ID: (sfid-20161011_162759_097239_51312C40) Subject: Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning To: Paul Bolle Cc: Luca Coelho , Intel Linux Wireless , Emmanuel Grumbach , Johannes Berg , Kalle Valo , Oren Givon , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Oct 11, 2016 at 9:09 AM, Chris Rorvick wrote: > I didn't receive your email so I'll try to respond via Paul's. >>> If this is really bothering you, I guess I could apply this patch for >>> now. But as I said, this is not solving the actual problem. >> >> Bikeshedding: I think IWL_INFO() is more appropriate, as info doesn't >> imply one needs to act on this message, while warn does imply that >> action is needed. > > Agreed. I still think making this a warning is appropriate, but it > seems pretty clear this is not an error. This has nothing to do with > how much it bothers me. An error tells the user something needs to be > fixed, but in this case the interface is working fine. Making it a > warning with an improved message will result in fewer people wasting > their time. I found your original email on lkml.org... should have looked there in the first place! Yes, if there is a fix for the underlying issue then that is obviously preferred. When I investigated this I saw several reports spanning at least a few distros and kernel versions with at least some concluding "this is normal". Again, thanks! Chris