Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:41961 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbcJLIOJ (ORCPT ); Wed, 12 Oct 2016 04:14:09 -0400 Message-ID: <1476258794.5271.12.camel@sipsolutions.net> (sfid-20161012_101428_337458_CBAF08AE) Subject: Re: [PATCH] mac80211: fix A-MSDU outer SA/DA From: Johannes Berg To: Michael Braun Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de Date: Wed, 12 Oct 2016 09:53:14 +0200 In-Reply-To: <1476118360-29009-1-git-send-email-michael-dev@fami-braun.de> References: <1476118360-29009-1-git-send-email-michael-dev@fami-braun.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote: > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS > values. "Need to" is perhaps a bit strongly worded, but whatever :) I was going to write a long reply and whatever - but I think that's all moot. As far as I can tell, you got this completely wrong, as you're changing the *inner* headers, not the *outer* header as you should? johannes