Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:56009 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755378AbcJLOjj (ORCPT ); Wed, 12 Oct 2016 10:39:39 -0400 From: "Valo, Kalle" To: Prameela Rani Garnepudi CC: "linux-wireless@vger.kernel.org" , "hofrat@osadl.org" , "xypron.glpk@gmx.de" , "prameela.garnepudi@redpinesignals.com" Subject: Re: [PATCH] rsi: update in vap_capabilities frame to device Date: Wed, 12 Oct 2016 14:39:33 +0000 Message-ID: <87bmypeimz.fsf@kamboji.qca.qualcomm.com> (sfid-20161012_163943_516185_F2C23D7A) References: <1474885981-6810-1-git-send-email-prameela.j04cs@gmail.com> <87k2ddej46.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87k2ddej46.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 12 Oct 2016 17:29:13 +0300") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Prameela Rani Garnepudi writes: > >> added vap status(add/delete) field in vap capabilities frame to device >> added sending vap capabilites frame(with vap status 'delete') in remove = interface >> >> Signed-off-by: Prameela Rani Garnepudi > > Why? How is this better now? I'm sure there is a good reason why you add > this but we don't know as the commit tells nothing we don't already know > just from looking at the patch. > > The most important part of commit log is to answer the question "Why?", > not "What?". Oh, and USE capitalisation, punctuation and so on in the commit log. It will be archived to git. --=20 Kalle Valo=