Return-path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:35921 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbcJDNes (ORCPT ); Tue, 4 Oct 2016 09:34:48 -0400 Date: Tue, 4 Oct 2016 08:34:46 -0500 From: Rob Herring To: Amitkumar Karwar Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org, rajatja@google.com, Xinming Hu Subject: Re: [PATCH RESEND v3] mwifiex: parse device tree node for PCIe Message-ID: <20161004133446.GD3065@rob-hp-laptop> (sfid-20161004_153450_387294_7889D14C) References: <1475167183-18376-1-git-send-email-akarwar@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1475167183-18376-1-git-send-email-akarwar@marvell.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Sep 29, 2016 at 10:09:43PM +0530, Amitkumar Karwar wrote: > From: Xinming Hu > > This patch derives device tree node from pcie bus layer framework. > Device tree bindings file has been renamed(marvell-sd8xxx.txt -> > marvell-8xxx.txt) to accomodate PCIe changes. > > Signed-off-by: Xinming Hu > Signed-off-by: Amitkumar Karwar > --- > v2: Included vendor and product IDs in compatible strings for PCIe > chipsets(Rob Herring) > v3: Patch is created using -M option so that it will only include diff of > original and renamed files(Rob Herring) > Resend v3: Resending the patch because I missed to include device tree mailing > while sending v3. > --- > .../{marvell-sd8xxx.txt => marvell-8xxx.txt} | 8 +++++--- > drivers/net/wireless/marvell/mwifiex/pcie.c | 20 ++++++++++++++++++++ > drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 3 ++- > 3 files changed, 27 insertions(+), 4 deletions(-) > rename Documentation/devicetree/bindings/net/wireless/{marvell-sd8xxx.txt => marvell-8xxx.txt} (91%) > > diff --git a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > similarity index 91% > rename from Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt > rename to Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > index c421aba..dfe5f8e 100644 > --- a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt > +++ b/Documentation/devicetree/bindings/net/wireless/marvell-8xxx.txt > @@ -1,8 +1,8 @@ > -Marvell 8897/8997 (sd8897/sd8997) SDIO devices > +Marvell 8897/8997 (sd8897/sd8997/pcie8997) SDIO/PCIE devices > ------ > > -This node provides properties for controlling the marvell sdio wireless device. > -The node is expected to be specified as a child node to the SDIO controller that > +This node provides properties for controlling the marvell sdio/pcie wireless device. Capitalize SDIO/PCIe > +The node is expected to be specified as a child node to the SDIO/PCIE controller that > connects the device to the system. > > Required properties: > @@ -10,6 +10,8 @@ Required properties: > - compatible : should be one of the following: > * "marvell,sd8897" > * "marvell,sd8997" > + * "pci11ab,2b42" > + * "pci1b4b,2b42" The string is pciVVVV,DDDD. Looks like you have vendor and device swapped. Rob