Return-path: Received: from 162-17-110-37-static.hfc.comcastbusiness.net ([162.17.110.37]:46726 "EHLO stuffed.shaftnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753827AbcJYSer (ORCPT ); Tue, 25 Oct 2016 14:34:47 -0400 Date: Tue, 25 Oct 2016 14:13:52 -0400 From: Solomon Peachy To: David Laight Cc: "'Arnd Bergmann'" , Kalle Valo , Johannes Berg , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] cw1200: fix bogus maybe-uninitialized warning Message-ID: <20161025181352.GB28536@shaftnet.org> (sfid-20161025_203511_373584_6DA6B9E4) References: <20161024154215.2863586-1-arnd@arndb.de> <063D6719AE5E284EB5DD2968C1650D6DB0209E9A@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5gNqxB1S1yM7hjW" In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6DB0209E9A@AcuExch.aculab.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: --b5gNqxB1S1yM7hjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2016 at 01:24:55PM +0000, David Laight wrote: > > - if (count > 1) { > > - /* We already released one buffer, now for the rest */ > > - ret =3D wsm_release_tx_buffer(priv, count - 1); > > - if (ret < 0) > > - return ret; > > - else if (ret > 0) > > - cw1200_bh_wakeup(priv); > > - } > > + /* We already released one buffer, now for the rest */ > > + ret =3D wsm_release_tx_buffer(priv, count - 1); > > + if (ret < 0) > > + return ret; > > + > > + if (ret > 0) > > + cw1200_bh_wakeup(priv); >=20 > That doesn't look equivalent to me (when count =3D=3D 1). I concur, this patch should not be applied in its current form. - Solomon --=20 Solomon Peachy pizza at shaftnet dot org Delray Beach, FL ^^ (email/xmpp) ^^ Quidquid latine dictum sit, altum viditur. --b5gNqxB1S1yM7hjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEABECAAYFAlgPoN8ACgkQPuLgii2759AS3gCfUKNTMDFd/WctTiPJIi6IyXuY C30AnR9RZTG8b8EJBU+CbZHPfwFyz4WZ =5eri -----END PGP SIGNATURE----- --b5gNqxB1S1yM7hjW--