Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47081 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755805AbcJLRWE (ORCPT ); Wed, 12 Oct 2016 13:22:04 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: rtlwifi: Fix regression caused by commit d86e64768859 From: Kalle Valo In-Reply-To: <20161010233211.13519-1-Larry.Finger@lwfinger.net> References: <20161010233211.13519-1-Larry.Finger@lwfinger.net> To: Larry Finger Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Larry Finger , "Stable [ 4 . 8+ ]" , Julia Lawall Message-Id: <20161012164507.087B761875@smtp.codeaurora.org> (sfid-20161012_192209_023804_23DFC52B) Date: Wed, 12 Oct 2016 16:45:07 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name based on the exact model of the card. > As the file names were stored in one of the members of that struct, > these drivers would fail with a kernel BUG splat when they tried to > update the firmware name. > > Rather than reverting the previous commit, I used a suggestion by > Johannes Berg and made the firmware file name pointers be local to > the routines that update the software variables. > > The configuration struct of rtl8192cu, which was not touched in the > previous patch, is now constantfied. > > Fixes: d86e64768859 ("rtlwifi: rtl818x: constify local structures") > Cc: Stable # 4.8 > Cc: Julia Lawall > Suggested-by: Johannes Berg > Signed-off-by: Larry Finger I got warnings and after a quick look they look valid but not sure: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c: In function ‘rtl92c_init_sw_vars’: drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c:179:6: warning: ‘fw_name’ may be used uninitialized in this function [-Wuninitialized] drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c: In function ‘rtl8723e_init_sw_vars’: drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c:187:6: warning: ‘fw_name’ may be used uninitialized in this function [-Wuninitialized] -- https://patchwork.kernel.org/patch/9370013/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches