Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48164 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750822AbcJCN3U (ORCPT ); Mon, 3 Oct 2016 09:29:20 -0400 From: Kalle Valo To: Arnd Bergmann Cc: Felix Fietkau , linux-wireless@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding References: <20160905095128.80560-1-nbd@nbd.name> <201609301636.43363.arnd@arndb.de> <557be2b8-5ff1-83ea-f6d1-6421c2465969@nbd.name> <201609301658.35039.arnd@arndb.de> Date: Mon, 03 Oct 2016 16:29:15 +0300 In-Reply-To: <201609301658.35039.arnd@arndb.de> (Arnd Bergmann's message of "Fri, 30 Sep 2016 16:58:34 +0200") Message-ID: <87vax9r26s.fsf@kamboji.qca.qualcomm.com> (sfid-20161003_152933_503333_0B4EA997) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > On Friday 30 September 2016, Felix Fietkau wrote: >> >> >> >> + device_type = "pci"; >> >> >> >> + mediatek,mtd-eeprom = <&factory 0x8000>; >> >> >> >> + mediatek,2ghz = <0>; >> >> > >> >> > It's not clear what the possible values for the 2ghz property are, >> >> > can you be more verbose in the description? How is <0> different >> >> > from no property? >> >> 0 means disabled, no property means unchanged (compared to EEPROM). >> > >> > Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ? >> > >> > If zero is the only possible value, there is no need to put a number in there. >> 1 is also possible, which will force-enable the capability. > > Ok, then both those values should be documented in the binding. Related to this, Martin sent patches which add generic bindings for enabling 2 Ghz and 5 Ghz bands. [RFC,1/3] Documentation: dt-bindings: add IEEE 802.11 binding documentation https://patchwork.kernel.org/patch/9359833/ [RFC,2/3] of: add IEEE 802.11 device configuration support code https://patchwork.kernel.org/patch/9359837/ -- Kalle Valo