Return-path: Received: from mail-yb0-f195.google.com ([209.85.213.195]:36514 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932678AbcKQSVC (ORCPT ); Thu, 17 Nov 2016 13:21:02 -0500 Subject: Re: [PATCH] rtlwifi: rtl8723be: Fix bug in ant_sel code from commit c18d8f509571 To: kvalo@codeaurora.org References: <20161117180533.16136-1-Larry.Finger@lwfinger.net> Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, Ping-Ke Shih , Stable From: Larry Finger Message-ID: <77ef0cb4-a21b-fad1-e36b-2a0875a6d42f@lwfinger.net> (sfid-20161117_192106_527498_13061410) Date: Thu, 17 Nov 2016 12:20:59 -0600 MIME-Version: 1.0 In-Reply-To: <20161117180533.16136-1-Larry.Finger@lwfinger.net> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 11/17/2016 12:05 PM, Larry Finger wrote: > From: Ping-Ke Shih > > In commit c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module > parameter"), wifi was fixed for those laptops that have only a single > antenna but have an incorrectly coded EEPROM. This error causes the > driver to select the wrong antenna. In that commit, one necessary change > that affects Bluetooth operation was missed. > > Fixes: c18d8f509571 ("rtlwifi: rtl8723be: Add antenna select module parameter") > Signed-off-by: Ping-Ke Shih > Signed-off-by: Larry Finger > Cc: Stable > --- > drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c > index aba60c3..cb046ec 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/hw.c > @@ -2664,9 +2664,12 @@ void rtl8723be_read_bt_coexist_info_from_hwpg(struct ieee80211_hw *hw, > } > > /* override ant_num / ant_path */ > - if (mod_params->ant_sel) > + if (mod_params->ant_sel) { > rtlpriv->btcoexist.btc_info.ant_num = > (mod_params->ant_sel == 1 ? ANT_X2 : ANT_X1); > + rtlpriv->btcoexist.btc_info.single_ant_path = > + (mod_params->ant_sel == 1 ? 0 : 1); > + } > } > > void rtl8723be_bt_reg_init(struct ieee80211_hw *hw) > Please drop this patch. It contains an error. Sorry, Larry