To: Johannes Berg <johannes.berg@intel.com>,
        "Coelho, Luciano" <luciano.coelho@intel.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Subject: scheduled scan interval
Message-ID: <bc071499-a8ef-2b0b-bfb7-42c96f1d369c@broadcom.com> (sfid-20161121_121925_232061_A6D5C8A4)
Date: Mon, 21 Nov 2016 12:19:16 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org

Hi Johannes, Luca,

The gscan work made me look at scheduled scan and the implementation of
it in brcmfmac. The driver ignored the interval parameter from
user-space. Now I am fixing that. One thing is that our firmware has a
minimum interval which can not be indicated in struct wiphy. The other
issue is how the maximum interval is used in the nl80211.c.

In nl80211_parse_sched_scan_plans() it is used against value passed in
NL80211_ATTR_SCHED_SCAN_INTERVAL and NL80211_SCHED_SCAN_PLAN_INTERVAL.
For the first one it caps the value to the maximum, but for the second
one it returns -EINVAL. I suspect this is done because maximum interval
was introduced with schedule scan plans, but it feels inconsistent.

Thoughts?

Regards,
Arend