Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:13658 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753274AbcKOKsl (ORCPT ); Tue, 15 Nov 2016 05:48:41 -0500 From: "Valo, Kalle" To: "michal.kazior@tieto.com" CC: Erik Stromdahl , linux-wireless , "ath10k@lists.infradead.org" Subject: Re: [RFC 09/12] ath10k: Mailbox address definitions Date: Tue, 15 Nov 2016 10:48:36 +0000 Message-ID: <871sydrpbu.fsf@qca.qualcomm.com> (sfid-20161115_114845_805236_93264347) References: <1479141222-8493-1-git-send-email-erik.stromdahl@gmail.com> <1479141222-8493-10-git-send-email-erik.stromdahl@gmail.com> In-Reply-To: (Michal Kazior's message of "Tue, 15 Nov 2016 11:31:28 +0100") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Michal Kazior writes: > On 14 November 2016 at 17:33, Erik Stromdahl w= rote: >> Address definitions for SDIO/mbox based chipsets. >> >> Signed-off-by: Erik Stromdahl >> --- >> drivers/net/wireless/ath/ath10k/hw.h | 53 +++++++++++++++++++++++++++= +++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless= /ath/ath10k/hw.h >> index 883547f..46142e9 100644 >> --- a/drivers/net/wireless/ath/ath10k/hw.h >> +++ b/drivers/net/wireless/ath/ath10k/hw.h >> @@ -814,6 +814,59 @@ struct ath10k_hw_ops { >> #define QCA9887_EEPROM_ADDR_LO_MASK 0x00ff0000 >> #define QCA9887_EEPROM_ADDR_LO_LSB 16 >> >> +#define MBOX_RESET_CONTROL_ADDRESS 0x00000000 >> +#define MBOX_HOST_INT_STATUS_ADDRESS 0x00000800 >> +#define MBOX_HOST_INT_STATUS_ERROR_LSB 7 >> +#define MBOX_HOST_INT_STATUS_ERROR_MASK 0x00000080 > > I would again suggest using Jakub's bitfield GET_FIELD stuff to get > rid of MASK+LSB and just have single define per register field. Kalle, > thoughts? Same comment as with the other patch, very much preferred but not a hard requirement. --=20 Kalle Valo=