Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986AbcKSXxo (ORCPT ); Sat, 19 Nov 2016 18:53:44 -0500 From: Jes Sorensen To: Barry Day Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 0/7] rtl8xxxu: Pending patches References: <1479505468-29383-1-git-send-email-Jes.Sorensen@redhat.com> <20161119014648.GA7140@testbox> <20161119023830.GA7324@testbox> Date: Sat, 19 Nov 2016 18:53:42 -0500 In-Reply-To: <20161119023830.GA7324@testbox> (Barry Day's message of "Sat, 19 Nov 2016 12:38:31 +1000") Message-ID: (sfid-20161120_005420_675314_5944E258) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Barry Day writes: > On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: >> Barry Day writes: >> > On Fri, Nov 18, 2016 at 04:44:21PM -0500, Jes.Sorensen@redhat.com wrote: >> >> From: Jes Sorensen >> >> >> >> Kalle, >> >> >> >> Please find attached a number of patches for the rtl8xxxu >> >> driver. >> >> >> >> The issues reported with wpa_supplicant on 8723bu still needs further >> >> investigation. >> >> >> > >> > The patch I posted that you want tested more will also fix the >> > wpa_supplicant issue. Currently I'm looking at why the tx rate is not >> > what it should be. I feel fixing that first will be beneficial for >> > fixing any other issues. >> >> Interesting, I was thinking that might be the case. I do want to dig >> into this further to understand it better. If we use your solution I >> will want to make sure we cover both gen1 and gen2 parts. >> >> > The recent merge has made my local branch of rtl8xxxu-devel 14 >> > commits ahead. >> > Do I need to do a reset and submit a new patch for the DWA-131 dongle? >> >> In general you need to use 'git pull --rebase' on my tree. I rebase it >> to stay in sync with Kalle's tree. >> >> The DWA-131 is the 8192eu? Sorry a bit behind and my mind is losing >> bits. If it's the patch you posted earlier I can dig it out and play >> with it - I am still catching up though, so please be patient. > > yes it's an 8192eu. Gotcha - how do you do your testing to reproduce the problem btw? Most of my testing is using the 8723au as a primary device and the next device as a follow-on, so I may not see as long a run with the device active as you see. > Would you accept a patch that adds a struct device pointer to rtl8xxxu_priv > and used as the device pointer in the logging functions? Then all the messages > will start with the driver name making them easier to find. How do you mean? Right now I have a struct usb_device pointer and dereference that for ->dev to use with dev_info() messages etc. Do you want to see more than that? Cheers, Jes