Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52478 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755322AbcK2Oyw (ORCPT ); Tue, 29 Nov 2016 09:54:52 -0500 From: Kalle Valo To: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Arend Van Spriel , Johannes Berg , linux-wireless Subject: Re: [PATCH 03/12] brcmfmac: move pno helper functions in separate source file References: <1479896731-5091-1-git-send-email-arend.vanspriel@broadcom.com> <1479896731-5091-4-git-send-email-arend.vanspriel@broadcom.com> <1480406267.10012.0.camel@sipsolutions.net> Date: Tue, 29 Nov 2016 16:54:46 +0200 In-Reply-To: (=?utf-8?Q?=22Rafa=C5=82_Mi=C5=82ecki=22's?= message of "Tue, 29 Nov 2016 13:29:19 +0100") Message-ID: <87vav6tjyh.fsf@kamboji.qca.qualcomm.com> (sfid-20161129_155456_760993_CC164D11) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Rafa=C5=82 Mi=C5=82ecki writes: > On 29 November 2016 at 10:23, Arend Van Spriel > wrote: >> On 29-11-2016 8:57, Johannes Berg wrote: >>> On Tue, 2016-11-29 at 08:08 +0100, Rafa=C5=82 Mi=C5=82ecki wrote: >>>> On 23 November 2016 at 11:25, Arend van Spriel >>>> wrote: >>>>> >>>>> Introducing new source file for pno related functionality. Moving >>>>> existing pno functions. >>>> >>>> Let me ask one basic question as I'm curious: what that PNO stands >>>> for? I couldn't find it explained in the code. >>> >>> It's an Android term - Preferred Network Offload(ing?) >> >> Yeah. The module is called pfn in our firmware, which stands for >> preferred network. So not sure whether it was a BRCM term morphed into >> Android term or vice versa. >> >> Kalle, >> >> If needed I could drop the use of the term and resubmit the series. > > I don't have anything against it, I was just trying to understand that > part of driver (which makes more sense now, thanks). I don't have any problems as these are already implemented, you are only moving code around. But if you were adding a new feature to the driver when an explanation for the acronym is very much preferred. --=20 Kalle Valo