Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51850 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755325AbcK1VMN (ORCPT ); Mon, 28 Nov 2016 16:12:13 -0500 From: Jes Sorensen To: Arnd Bergmann Cc: Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtl8xxxu: fix tx rate debug output References: <20161128210815.2368509-1-arnd@arndb.de> Date: Mon, 28 Nov 2016 16:12:12 -0500 In-Reply-To: <20161128210815.2368509-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 28 Nov 2016 22:08:04 +0100") Message-ID: (sfid-20161128_221246_654420_476A7EF3) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > We accidentally print the rate before we know it for txdesc_v2: Hi Arnd, Thanks for the patch - Barry Day already posted a patch for this which Kalle has applied to the wireless tree. Cheers, Jes > > wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8xxxu_fill_txdesc_v2': > wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4848:3: error: 'rate' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > txdesc_v1 got it right, so let's do it the same way here. > > Fixes: b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order to have access to retry count") > Signed-off-by: Arnd Bergmann > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > index 04141e57b8ae..a9137abc3ad9 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c > @@ -4844,16 +4844,16 @@ rtl8xxxu_fill_txdesc_v2(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr, > > tx_desc40 = (struct rtl8xxxu_txdesc40 *)tx_desc32; > > - if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX) > - dev_info(dev, "%s: TX rate: %d, pkt size %d\n", > - __func__, rate, cpu_to_le16(tx_desc40->pkt_size)); > - > if (rate_flags & IEEE80211_TX_RC_MCS && > !ieee80211_is_mgmt(hdr->frame_control)) > rate = tx_info->control.rates[0].idx + DESC_RATE_MCS0; > else > rate = tx_rate->hw_value; > > + if (rtl8xxxu_debug & RTL8XXXU_DEBUG_TX) > + dev_info(dev, "%s: TX rate: %d, pkt size %d\n", > + __func__, rate, cpu_to_le16(tx_desc40->pkt_size)); > + > seq_number = IEEE80211_SEQ_TO_SN(le16_to_cpu(hdr->seq_ctrl)); > > tx_desc40->txdw4 = cpu_to_le32(rate);