Return-path: Received: from coyote.holtmann.net ([212.227.132.17]:35186 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753437AbcKIUcW (ORCPT ); Wed, 9 Nov 2016 15:32:22 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: [PATCH 1/2] wcn36xx: Correct Kconfig dependency From: Marcel Holtmann In-Reply-To: <1478714571-4841-1-git-send-email-bjorn.andersson@linaro.org> Date: Wed, 9 Nov 2016 21:32:18 +0100 Cc: Andy Gross , Eugene Krasnikov , Kalle Valo , wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20975667-9D09-430C-A70B-D0C38A320C86@holtmann.org> (sfid-20161109_213246_552078_EC04BBB6) References: <1478714571-4841-1-git-send-email-bjorn.andersson@linaro.org> To: Bjorn Andersson Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Bjorn, > In the case SMD or WCNSS_CTRL are compiled as modules, wcn36xx must be > compiled as module as well, so we need to mention this dependency. > But we still want allow the driver to be compiled in case either of > those are =n, for compile testing reasons. > > Signed-off-by: Bjorn Andersson > --- > drivers/net/wireless/ath/wcn36xx/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/ath/wcn36xx/Kconfig b/drivers/net/wireless/ath/wcn36xx/Kconfig > index 591ebaea8265..4b83e87f0b94 100644 > --- a/drivers/net/wireless/ath/wcn36xx/Kconfig > +++ b/drivers/net/wireless/ath/wcn36xx/Kconfig > @@ -1,6 +1,8 @@ > config WCN36XX > tristate "Qualcomm Atheros WCN3660/3680 support" > depends on MAC80211 && HAS_DMA > + depends on QCOM_WCNSS_CTRL || QCOM_WCNSS_CTRL=n > + depends on QCOM_SMD || QCOM_SMD=n I thought we wanted to move towards being able to compile the WiFi and Bluetooth support without requiring QCOM_SMD. Regards Marcel