Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:34216 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbcKSCqp (ORCPT ); Fri, 18 Nov 2016 21:46:45 -0500 Received: by mail-pg0-f65.google.com with SMTP id e9so21829943pgc.1 for ; Fri, 18 Nov 2016 18:46:44 -0800 (PST) Date: Sat, 19 Nov 2016 12:38:31 +1000 From: Barry Day To: Jes Sorensen Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org, Larry.Finger@lwfinger.net Subject: Re: [PATCH 0/7] rtl8xxxu: Pending patches Message-ID: <20161119023830.GA7324@testbox> (sfid-20161119_034723_003574_A04EA1D2) References: <1479505468-29383-1-git-send-email-Jes.Sorensen@redhat.com> <20161119014648.GA7140@testbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Nov 18, 2016 at 09:00:10PM -0500, Jes Sorensen wrote: > Barry Day writes: > > On Fri, Nov 18, 2016 at 04:44:21PM -0500, Jes.Sorensen@redhat.com wrote: > >> From: Jes Sorensen > >> > >> Kalle, > >> > >> Please find attached a number of patches for the rtl8xxxu > >> driver. > >> > >> The issues reported with wpa_supplicant on 8723bu still needs further > >> investigation. > >> > > > > The patch I posted that you want tested more will also fix the > > wpa_supplicant issue. Currently I'm looking at why the tx rate is not > > what it should be. I feel fixing that first will be beneficial for > > fixing any other issues. > > Interesting, I was thinking that might be the case. I do want to dig > into this further to understand it better. If we use your solution I > will want to make sure we cover both gen1 and gen2 parts. > > > The recent merge has made my local branch of rtl8xxxu-devel 14 commits ahead. > > Do I need to do a reset and submit a new patch for the DWA-131 dongle? > > In general you need to use 'git pull --rebase' on my tree. I rebase it > to stay in sync with Kalle's tree. > > The DWA-131 is the 8192eu? Sorry a bit behind and my mind is losing > bits. If it's the patch you posted earlier I can dig it out and play > with it - I am still catching up though, so please be patient. > > Cheers, > Jes > > yes it's an 8192eu. Would you accept a patch that adds a struct device pointer to rtl8xxxu_priv and used as the device pointer in the logging functions? Then all the messages will start with the driver name making them easier to find. Barry