Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47004 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932568AbcKQLN3 (ORCPT ); Thu, 17 Nov 2016 06:13:29 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() From: Kalle Valo In-Reply-To: <1478662648-70698-1-git-send-email-jcliang@chromium.org> References: <1478662648-70698-1-git-send-email-jcliang@chromium.org> To: Ricky Liang Cc: unlisted-recipients:; (no To-header on input) Ricky Liang , Amitkumar Karwar , Nishant Sarmukadam , linux-wireless@vger.kernel.org (open list:MARVELL MWIFIEX WIRELESS DRIVER), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Message-Id: <20161117111328.CE36E61652@smtp.codeaurora.org> (sfid-20161117_121404_319370_ABB5F4F9) Date: Thu, 17 Nov 2016 11:13:28 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Ricky Liang wrote: > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffffffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@ > 07 10 54 57 20 34 04 1e 64 05 24 84 03 24 95 04 ..TW 4..d.$..$.. > backtrace: > [] create_object+0x164/0x2b4 > [] kmemleak_alloc+0x50/0x88 > [] __kmalloc_track_caller+0x1bc/0x264 > [] kmemdup+0x38/0x64 > [] mwifiex_fill_new_bss_desc+0x3c/0x130 [mwifiex] > [] mwifiex_save_curr_bcn+0x4ec/0x640 [mwifiex] > [] mwifiex_handle_event_ext_scan_report+0x1d4/0x268 [mwifiex] > [] mwifiex_process_sta_event+0x378/0x898 [mwifiex] > [] mwifiex_process_event+0x1a8/0x1e8 [mwifiex] > [] mwifiex_main_process+0x258/0x534 [mwifiex] > [] 0xffffffbffc258858 > [] process_sdio_pending_irqs+0xf8/0x160 > [] sdio_irq_thread+0x9c/0x1a4 > [] kthread+0xf4/0x100 > [] ret_from_fork+0xc/0x50 > [] 0xffffffffffffffff > > Signed-off-by: Ricky Liang > Acked-by: Amitkumar Karwar > Reviewed-by: Brian Norris Patch applied to wireless-drivers-next.git, thanks. 5ff262229378 mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() -- https://patchwork.kernel.org/patch/9418433/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches