Return-path: Received: from mail-vk0-f42.google.com ([209.85.213.42]:33271 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753320AbcLMQlW (ORCPT ); Tue, 13 Dec 2016 11:41:22 -0500 Received: by mail-vk0-f42.google.com with SMTP id 137so69886867vkl.0 for ; Tue, 13 Dec 2016 08:41:22 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <87mvg0kqno.fsf@purkki.adurom.net> References: <8c273c9c41f51b34bb3115086f1d776895580637.1481575835.git.luto@kernel.org> <8818c45b9ec6a04d85fabf9bb437cf119fd23659.1481575835.git.luto@kernel.org> <87mvg0kqno.fsf@purkki.adurom.net> From: Andy Lutomirski Date: Tue, 13 Dec 2016 08:41:01 -0800 Message-ID: (sfid-20161213_174436_197434_1773ED3F) Subject: Re: [PATCH] orinoco: Use shash instead of ahash for MIC calculations To: Kalle Valo Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , USB list , Linux Wireless List , Eric Biggers , linux-crypto@vger.kernel.org, Herbert Xu , Stephan Mueller Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Dec 13, 2016 at 3:35 AM, Kalle Valo wrote: > Andy Lutomirski writes: > >> Eric Biggers pointed out that the orinoco driver pointed scatterlists >> at the stack. >> >> Fix it by switching from ahash to shash. The result should be >> simpler, faster, and more correct. >> >> Cc: stable@vger.kernel.org # 4.9 only >> Reported-by: Eric Biggers >> Signed-off-by: Andy Lutomirski > > "more correct"? Does this fix a real user visible bug or what? And why > just stable 4.9, does this maybe have something to do with > CONFIG_VMAP_STACK? Whoops, I had that text in some other patches but forgot to put it in this one. It'll blow up with CONFIG_VMAP_STACK=y if a debug option like CONFIG_DEBUG_VIRTUAL=y is set. It may work by accident if debugging is off. --Andy