Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:35960 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbcL1VhQ (ORCPT ); Wed, 28 Dec 2016 16:37:16 -0500 MIME-Version: 1.0 In-Reply-To: <491a5af2-449d-4b2a-c4ed-af0e89b2ca78@broadcom.com> References: <20161228155955.25518-1-zajec5@gmail.com> <20161228155955.25518-2-zajec5@gmail.com> <491a5af2-449d-4b2a-c4ed-af0e89b2ca78@broadcom.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Wed, 28 Dec 2016 22:28:13 +0100 Message-ID: (sfid-20161228_223719_760591_05ED351F) Subject: Re: [PATCH 2/2] cfg80211: reg: support ieee80211-(min|max)-center-freq DT properties To: Arend van Spriel Cc: Kalle Valo , "linux-wireless@vger.kernel.org" , Martin Blumenstingl , Felix Fietkau , Arnd Bergmann , "devicetree@vger.kernel.org" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 28 December 2016 at 22:07, Arend van Spriel wrote: > On 28-12-16 16:59, Rafa=C5=82 Mi=C5=82ecki wrote: >> From: Rafa=C5=82 Mi=C5=82ecki >> >> They allow specifying hardware limitations of supported channels. This >> may be useful for specifying single band devices or devices that support >> only some part of the whole band. >> E.g. some tri-band routers have separated radios for lower and higher >> part of 5 GHz band. >> >> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki >> --- >> net/wireless/reg.c | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/net/wireless/reg.c b/net/wireless/reg.c >> index 5dbac37..35ba5c7 100644 >> --- a/net/wireless/reg.c >> +++ b/net/wireless/reg.c >> @@ -1123,6 +1123,26 @@ const char *reg_initiator_name(enum nl80211_reg_i= nitiator initiator) >> } >> EXPORT_SYMBOL(reg_initiator_name); >> >> +static bool reg_center_freq_of_valid(struct wiphy *wiphy, >> + struct ieee80211_channel *chan) >> +{ >> + struct device_node *np =3D wiphy_dev(wiphy)->of_node; >> + u32 val; >> + >> + if (!np) >> + return true; >> + >> + if (!of_property_read_u32(np, "ieee80211-min-center-freq", &val) &= & >> + chan->center_freq < KHZ_TO_MHZ(val)) >> + return false; >> + >> + if (!of_property_read_u32(np, "ieee80211-max-center-freq", &val) &= & >> + chan->center_freq > KHZ_TO_MHZ(val)) >> + return false; > > I suspect these functions rely on CONFIG_OF. So might not build for > !CONFIG_OF. I compiled it with # CONFIG_OF is not set Can you test it and provide a non-working config if you see a compilation error, please? --=20 Rafa=C5=82