Return-path: Received: from mail-lf0-f66.google.com ([209.85.215.66]:33684 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbcL1Ujz (ORCPT ); Wed, 28 Dec 2016 15:39:55 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161228155955.25518-1-zajec5@gmail.com> From: Martin Blumenstingl Date: Wed, 28 Dec 2016 21:39:32 +0100 Message-ID: (sfid-20161228_214016_631047_458E7996) Subject: Re: [PATCH 1/2] dt-bindings: document common IEEE 802.11 frequency properties To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , Kalle Valo , "linux-wireless@vger.kernel.org" , Felix Fietkau , Arnd Bergmann , "devicetree@vger.kernel.org" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Dec 28, 2016 at 9:32 PM, Rafa=C5=82 Mi=C5=82ecki = wrote: > On 28 December 2016 at 21:05, Arend van Spriel > wrote: >> On 28-12-16 16:59, Rafa=C5=82 Mi=C5=82ecki wrote: >>> From: Rafa=C5=82 Mi=C5=82ecki >>> >>> This new file should be used for properties handled at higher level and >>> so usable with all drivers. >>> >>> Signed-off-by: Rafa=C5=82 Mi=C5=82ecki >>> --- >>> .../devicetree/bindings/net/wireless/ieee80211.txt | 16 ++++++++= ++++++++ >>> 1 file changed, 16 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/wireless/ieee= 80211.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/ieee80211.t= xt b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>> new file mode 100644 >>> index 0000000..c762769 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/wireless/ieee80211.txt >>> @@ -0,0 +1,16 @@ >>> +Common IEEE 802.11 properties >>> + >>> +This provides documentation of common properties that are handled by a= proper >>> +net layer and don't require extra driver code. >> >> Please do not make any assumptions on how DT properties are handled nor >> by what. Just state that these properties apply to all wireless devices >> and are applicable to device specific bindings. > > OK, I'll try to improve this description. > > >>> +Optional properties: >>> + - ieee80211-min-center-freq : minimal supported frequency in KHz >>> + - ieee80211-max-center-freq : maximal supported frequency in KHz >>> + >>> +Example: >>> + >>> +pcie@0,0 { >>> + reg =3D <0x0000 0 0 0 0>; >>> + ieee80211-min-center-freq =3D <2437000>; >>> + ieee80211-max-center-freq =3D <2457000>; >>> +}; >> >> Is this the proper level to define it. I was expecting a child node of >> the pci(e) controller. Maybe I am misreading the example. > > This is device node, not a controller node (and yes, it's complete > node). You just need to add such a node inside the controller one. you should name the node wifi@0,0 instead. I revised my ath9k OF binding documentation due to similar concerns (and after seeing the result I must admit that they were right). you can have a look at the result here: [0] apart from that: thanks for the patch, I will try this as soon as possible! Regards, Martin [0] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/= bindings/net/wireless/qca%2Cath9k.txt