Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:18152 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbcLAFNw (ORCPT ); Thu, 1 Dec 2016 00:13:52 -0500 From: "Valo, Kalle" To: Bjorn Andersson CC: "k.eugene.e@gmail.com" , Andy Gross , "wcn36xx@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() Date: Thu, 1 Dec 2016 05:13:41 +0000 Message-ID: <874m2otenv.fsf@kamboji.qca.qualcomm.com> (sfid-20161201_061417_351361_97289A74) References: <1479190014-11297-1-git-send-email-bjorn.andersson@linaro.org> <20161118183541.GI28340@tuxbot> <877f7vimyg.fsf@kamboji.qca.qualcomm.com> <878ts0u7z3.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <878ts0u7z3.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 30 Nov 2016 20:40:32 +0200") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > "Valo, Kalle" writes: > >> Bjorn Andersson writes: >> >>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >>> >>>> Bjorn Andersson wrote: >>>> > The correct include file for getting errno constants and ERR_PTR() i= s >>>> > linux/err.h, rather than linux/errno.h, so fix the include. >>>> >=20 >>>> > Fixes: e8b123e60084 ("soc: qcom: smem_state: Add stubs for disabled = smem_state") >>>> > Acked-by: Andy Gross >>>> > Signed-off-by: Bjorn Andersson >>>>=20 >>>> For some reason this fails to compile now. Can you take a look, please= ? >>>>=20 >>>> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn= 36xx.ko] undefined! >>>> make[1]: *** [__modpost] Error 1 >>>> make: *** [modules] Error 2 >>>>=20 >>>> 5 patches set to Changes Requested. >>>>=20 >>>> 9429045 [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR() >>>> 9429047 [v5,2/5] wcn36xx: Transition driver to SMD client >>> >>> This patch was updated with the necessary depends in Kconfig to catch >>> this exact issue and when I pull in your .config (which has QCOM_SMD=3D= n, >>> QCOM_WCNSS_CTRL=3Dn and WCN36XX=3Dy) I can build this just fine. >>> >>> I've tested the various combinations and it seems to work fine. Do you >>> have any other patches in your tree? >> >> This was with the pending branch of my ath.git tree. There are other >> wireless patches (ath10k etc) but I would guess they don't affect here. >> >>> Any stale objects? >> >> Not sure what you mean with this question, but I didn't run 'make clean' >> if that's what you are asking. >> >>> Would you mind retesting this, before I invest more time in trying to >>> reproduce the issue you're seeing? >> >> Sure, I'll take a look but that might take few days. > > I didn't find enough time to look at this in detail. I applied this to > my ath.git pending branch, let's see what the kbuild bot finds. It found the same problem. Interestingly I'm also building x86 with 32 bit, maybe it's related? tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git pendi= ng head: 1ea16a1c457939b4564643f7637d5cc639a8d3b7 commit: 5eb09c672b01460804fd49b1c9cc7d1072a102f0 [96/99] wcn36xx: Transitio= n driver to SMD client config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: git checkout 5eb09c672b01460804fd49b1c9cc7d1072a102f0 # save the attached .config to linux build tree make ARCH=3Di386=20 All errors (new ones prefixed by >>): >> ERROR: "qcom_wcnss_open_channel" [drivers/net/wireless/ath/wcn36xx/wcn36= xx.ko] undefined! --=20 Kalle Valo=