Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:52432 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495AbcLIIu4 (ORCPT ); Fri, 9 Dec 2016 03:50:56 -0500 From: Kalle Valo To: Dan Carpenter Cc: devel@driverdev.osuosl.org, Ping-Ke Shih , linux-wireless@vger.kernel.org, Larry Finger Subject: Re: [PATCH 10/14] rtlwifi: Add BTC_TRACE_STRING to new btcoex References: <20161202014833.6856-1-Larry.Finger@lwfinger.net> <20161202014833.6856-11-Larry.Finger@lwfinger.net> <20161205213447.GJ8176@mwanda> <6442d5c7-f083-0e98-490b-dd18a5a4d316@lwfinger.net> <20161206071340.GB10292@kroah.com> <871sxkdjeh.fsf@kamboji.qca.qualcomm.com> <20161207133219.GM8176@mwanda> <87y3zqbq8h.fsf@kamboji.qca.qualcomm.com> <20161208115049.GR8176@mwanda> <20161208115450.GK8244@mwanda> Date: Fri, 09 Dec 2016 10:50:50 +0200 In-Reply-To: <20161208115450.GK8244@mwanda> (Dan Carpenter's message of "Thu, 8 Dec 2016 14:54:50 +0300") Message-ID: <87vaut32qd.fsf@kamboji.qca.qualcomm.com> (sfid-20161209_095104_641661_730D69AE) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Dan Carpenter writes: > On Thu, Dec 08, 2016 at 02:50:49PM +0300, Dan Carpenter wrote: >> On Thu, Dec 08, 2016 at 01:43:42PM +0200, Kalle Valo wrote: >> > But it would make me very happy if someone would add a similar grouping >> > functionality to dyndbg to make it easy to enable a set of debug >> > messages in a driver. >> >> Thats seems like a reasonable thing as well. > > I actually like the ath code... We could easily change it to be more > generic and make it a top level function for everyone to use. That would be great. And maybe add a sysfs file with a description different levels, like module parameters have. Too bad that I can't work on that, too much stuff on my plate right now. -- Kalle Valo