Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:35152 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965577AbdAILTc (ORCPT ); Mon, 9 Jan 2017 06:19:32 -0500 Received: by mail-pg0-f48.google.com with SMTP id 194so13594547pgd.2 for ; Mon, 09 Jan 2017 03:19:32 -0800 (PST) Subject: Re: [PATCH] RFC: Universal scan proposal To: Johannes Berg , Dmitry Shmidt References: <94eb2c110db85c2379054172dad0@google.com> <1480948100.31788.15.camel@sipsolutions.net> <1481093061.4092.17.camel@sipsolutions.net> <93d4475c-58bd-d497-3347-a988d551f374@broadcom.com> <1481645205.20412.32.camel@sipsolutions.net> <1483536510.7312.5.camel@sipsolutions.net> <1483616763.4394.8.camel@sipsolutions.net> <1483958725.17582.18.camel@sipsolutions.net> Cc: linux-wireless@vger.kernel.org From: Arend Van Spriel Message-ID: <0ddf60ad-85d8-e54b-db25-b31bbd9590c5@broadcom.com> (sfid-20170109_122103_139390_5A9389B8) Date: Mon, 9 Jan 2017 12:19:28 +0100 MIME-Version: 1.0 In-Reply-To: <1483958725.17582.18.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 9-1-2017 11:45, Johannes Berg wrote: > On Thu, 2017-01-05 at 12:45 -0800, Dmitry Shmidt wrote: >> >>> Oh, then again, maybe you're thinking of full-MAC devices - does a >>> roam/autojoin scan really already *imply* a new connection? And if >>> so, do we have to do it that way, or can we remove that type of >>> action and make a connection decision in higher layers, so it's >>> really the same as "report when suitable results are found"? >> >> We need to consider case when FW may do some actions like connection >> during roaming/autojoin. > > Ok. I was unsure if that was happening. So you're saying that the scan > parameters are determined by the host, and the scan is triggered from > there, but the action (like roaming) is taken by the firmware? > > How does that differ to > > 1) the scan being started by the firmware, possibly based on the BSS > selection configuration Arend added? Currently, the BSS selection configuration is used in CMD_CONNECT. It can probably be used for scanning as well. The presence of the attribute would indicate the scan may result in a roam or connect event. > 2) the scan result being reported to the host, and BSS selection done > there? Not sure if we need to consider this one, do we? >> It depends how we want to make it flexible. For example we >> may allow to FW to report even usual scan results not one by one >> but as a chunk. > > Firmware can do that, but is there any point in doing that in the > cfg80211 API? If it properly has full results, the driver can always > unbundle them and call the report function for each BSS and everything > should work just fine, no? Agree. >>> There's a bit more complication wrt. the level of detail in results >>> though - sometimes the result may include all IEs (normal/sched >>> scan), sometimes it may not ("history scan") - are we sure we >>> really only need one new get_scan_results()? >> >> Maybe not - it is possible I missed something. > > I was hoping you could clarify the requirements :-) > >> Also looking at our >> conversation I think we should consider separate command pair >> for history scan. > > Perhaps, yes. Although perhaps having it triggered through the same > (new or extended) command, but results reported depending on the > "report type" would make sense. I think we need to clarify the exact > requirements before we make that call. Leaning towards single initiate command and a notification and results command per "report type". Regards, Arend