Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:48724 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbdAaGfW (ORCPT ); Tue, 31 Jan 2017 01:35:22 -0500 From: Kalle Valo To: Tony Lindgren Cc: Pavel Machek , Pali =?utf-8?Q?Roh=C3=A1r?= , Arend Van Spriel , Ming Lei , "Luis R. Rodriguez" , Greg Kroah-Hartman , David Gnedt , Michal Kazior , Daniel Wagner , Sebastian Reichel , Ivaylo Dimitrov , Aaro Koskinen , Grazvydas Ignotas , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data References: <20170127101043.GD24223@pali> <20170127103408.GG24223@pali> <87bmus7mfk.fsf@kamboji.qca.qualcomm.com> <20170127115706.GH24223@pali> <8737g47kpd.fsf@kamboji.qca.qualcomm.com> <20170127131146.GI24223@pali> <87bmus5xyc.fsf@kamboji.qca.qualcomm.com> <20170127194012.GE20571@amd> <20170130175309.GY7403@atomide.com> Date: Tue, 31 Jan 2017 08:35:09 +0200 In-Reply-To: <20170130175309.GY7403@atomide.com> (Tony Lindgren's message of "Mon, 30 Jan 2017 09:53:09 -0800") Message-ID: <8737fzrb36.fsf@kamboji.qca.qualcomm.com> (sfid-20170131_073532_057514_FBFD056F) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Tony Lindgren writes: > * Pavel Machek [170127 11:41]: >> On Fri 2017-01-27 17:23:07, Kalle Valo wrote: >> > Pali Roh=C3=A1r writes: >> >=20 >> > > On Friday 27 January 2017 14:26:22 Kalle Valo wrote: >> > >> Pali Roh=C3=A1r writes: >> > >>=20 >> > >> > 2) It was already tested that example NVS data can be used for N9= 00 e.g. >> > >> > for SSH connection. If real correct data are not available it is = better >> > >> > to use at least those example (and probably log warning message) = so user >> > >> > can connect via SSH and start investigating where is problem. >> > >>=20 >> > >> I disagree. Allowing default calibration data to be used can be >> > >> unnoticed by user and left her wondering why wifi works so badly. >> > > >> > > So there are only two options: >> > > >> > > 1) Disallow it and so these users will have non-working wifi. >> > > >> > > 2) Allow those data to be used as fallback mechanism. >> > > >> > > And personally I'm against 1) because it will break wifi support for >> > > *all* Nokia N900 devices right now. >> >=20 >> > All two of them? :) >>=20 >> Umm. You clearly want a flock of angry penguins at your doorsteps :-). > > Well this silly issue of symlinking and renaming nvs files in a standard > Linux distro was also hitting me on various devices with wl12xx/wl18xx > trying to use the same rootfs. > > Why don't we just set a custom compatible property for n900 that then > picks up some other nvs file instead of the default? Please don't. An ugly kernel workaround in kernel because of user space problems is a bad idea. wl1251 should just ask for NVS file from user space, it shouldn't care if it's a "default" file or something else. That's a user space policy decision. Why can't you do something like this: * rename the NVS file linux-firmware to wl1251-nvs.bin.example * before distro updates linux-firmware create yours own deb/rpm/whatever package "wl1251-firmware" which installs your flavor of nvs file (or the user fallback helper if more dynamic functionality is preferred) --=20 Kalle Valo