Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:49394 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbdAaTAR (ORCPT ); Tue, 31 Jan 2017 14:00:17 -0500 Subject: Re: [PATCH v2 2/2] mac80211: store tx power value from user to station To: Ashok Raj Nagarajan , linux-wireless@vger.kernel.org References: <1485888101-23454-1-git-send-email-arnagara@qti.qualcomm.com> <1485888101-23454-2-git-send-email-arnagara@qti.qualcomm.com> Cc: johannes@sipsolutions.net, arnagara@codeaurora.org, ath10k@lists.infradead.org From: Ben Greear Message-ID: (sfid-20170131_200048_781942_7EB9B9CE) Date: Tue, 31 Jan 2017 11:00:06 -0800 MIME-Version: 1.0 In-Reply-To: <1485888101-23454-2-git-send-email-arnagara@qti.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/31/2017 10:41 AM, Ashok Raj Nagarajan wrote: > This patch introduce a new driver callback drv_sta_set_txpwr. This API will > copy the transmit power value passed from user space and call the driver > callback to set the tx power for the station. > > Signed-off-by: Ashok Raj Nagarajan > --- > include/net/mac80211.h | 6 ++++++ > net/mac80211/cfg.c | 7 +++++++ > net/mac80211/driver-ops.c | 21 +++++++++++++++++++++ > net/mac80211/driver-ops.h | 5 +++++ > net/mac80211/trace.h | 27 +++++++++++++++++++++++++++ > 5 files changed, 66 insertions(+) > > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index 5345d35..e059d5a 100644 > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -1777,6 +1777,8 @@ struct ieee80211_sta_rates { > * This is defined by the spec (IEEE 802.11-2012 section 8.3.2.2 NOTE 2). > * @support_p2p_ps: indicates whether the STA supports P2P PS mechanism or not. > * @max_rc_amsdu_len: Maximum A-MSDU size in bytes recommended by rate control. > + * @txpwr: indicates the tx power, in dBm, to be used when sending data frames > + * to the STA. Value of 0 means, automatic (default) tx power. Atheros NICs use 1/2 dBm increments internally, so maybe pass down mBm to the driver so you don't loose the granularity? (Other NICs may potentially have even finer control.) Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com