Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50570 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbdAUM7R (ORCPT ); Sat, 21 Jan 2017 07:59:17 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: iwlwifi: fix kernel crash when unregistering thermal zone From: Kalle Valo In-Reply-To: References: To: Jens Axboe Cc: Johannes Berg , linux-wireless@vger.kernel.org Message-Id: <20170121125917.47BA060851@smtp.codeaurora.org> (sfid-20170121_135921_749183_F3053557) Date: Sat, 21 Jan 2017 12:59:17 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Jens Axboe wrote: > A recent firmware change seems to have enabled thermal zones on the > iwlwifi driver. Unfortunately, my device fails when registering the > thermal zone. This doesn't stop the driver from attempting to unregister > the thermal zone at unload time, triggering a NULL pointer deference in > strlen() off the thermal_zone_device_unregister() path. > > Don't unregister if name is NULL, for that case we failed registering. > Do the same for the cooling zone. > > Signed-off-by: Jens Axboe Patch applied to wireless-drivers.git, thanks. 92549cdc288f iwlwifi: fix kernel crash when unregistering thermal zone -- https://patchwork.kernel.org/patch/9522187/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches