Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49660 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbdAaUP4 (ORCPT ); Tue, 31 Jan 2017 15:15:56 -0500 Subject: Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h To: Russell King , linux-mips@linux-mips.org, linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, target-devel@vger.kernel.org Cc: "David S. Miller" , Florian Fainelli References: <20170131191704.GA8281@n2100.armlinux.org.uk> From: Timur Tabi Message-ID: (sfid-20170131_211602_977025_70BE3F05) Date: Tue, 31 Jan 2017 14:15:50 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 01/31/2017 01:19 PM, Russell King wrote: > drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' > > Add linux/phy.h to emac-sgmii.c > > Signed-off-by: Russell King > --- > drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + The version of emac-sgmii.c on net-next does not need this fixed. I already removed all references to phy_device in commit "net: qcom/emac: always use autonegotiation to configure the SGMII link". -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.