Return-path: Received: from mail-oi0-f66.google.com ([209.85.218.66]:36518 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdAQWlN (ORCPT ); Tue, 17 Jan 2017 17:41:13 -0500 Received: by mail-oi0-f66.google.com with SMTP id u143so15899328oif.3 for ; Tue, 17 Jan 2017 14:41:12 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20170117222909.2880-1-gavinli@thegavinli.com> References: <20170117222909.2880-1-gavinli@thegavinli.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Tue, 17 Jan 2017 23:41:11 +0100 Message-ID: (sfid-20170117_234118_028024_B21FB690) Subject: Re: [PATCH] brcmfmac: fix incorrect event channel deduction To: gavinli@thegavinli.com Cc: Arend Van Spriel , Franky Lin , Hante Meuleman , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , Gavin Li Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 17 January 2017 at 23:29, wrote: > From: Gavin Li > > brcmf_sdio_fromevntchan() was being called on the the hardware header > rather than the software header, causing some frames to be > mischaracterized as on the event channel rather than the data channel. > This fixes the performance regression introduced in commit c56caa9d > where event processing is done separately. This should be: in commit c56caa9db8ab ("brcmfmac: screening firmware event packet") where (...) You should also use Fixes: c56caa9db8ab ("brcmfmac: screening firmware event packet") where (...) > Signed-off-by: Gavin Li Please add also: Cc: stable@vger.kernel.org # 4.6+