Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50980 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbdAUH4k (ORCPT ); Sat, 21 Jan 2017 02:56:40 -0500 From: Kalle Valo To: Jens Axboe , Luca Coelho Cc: Johannes Berg , linux-wireless@vger.kernel.org Subject: Re: iwlwifi: fix kernel crash when unregistering thermal zone References: Date: Sat, 21 Jan 2017 09:56:34 +0200 In-Reply-To: (Jens Axboe's message of "Tue, 17 Jan 2017 14:22:24 -0800") Message-ID: <87a8akhmml.fsf@purkki.adurom.net> (sfid-20170121_085659_894354_88CEA330) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Jens Axboe writes: > A recent firmware change seems to have enabled thermal zones on the > iwlwifi driver. Unfortunately, my device fails when registering the > thermal zone. This doesn't stop the driver from attempting to unregister > the thermal zone at unload time, triggering a NULL pointer deference in > strlen() off the thermal_zone_device_unregister() path. > > Don't unregister if name is NULL, for that case we failed registering. > Do the same for the cooling zone. > > Signed-off-by: Jens Axboe > > --- > > Would be great if this could go into the current series, as sometimes I > have to reload the driver. Right now I can't, since it crashes... Luca, can I take this directly to wireless-drivers? This is an important fix and we should get it to Linus' tree ASAP. -- Kalle Valo