Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:41346 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdAROnr (ORCPT ); Wed, 18 Jan 2017 09:43:47 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [1/1] net: wireless: marvell: fix improper return value From: Kalle Valo In-Reply-To: <1480760857-4549-1-git-send-email-bianpan2016@163.com> References: <1480760857-4549-1-git-send-email-bianpan2016@163.com> To: Pan Bian Cc: Andreas Kemnade , Johannes Berg , libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Message-Id: <20170118144346.8E91760818@smtp.codeaurora.org> (sfid-20170118_154403_555612_FA87AFA7) Date: Wed, 18 Jan 2017 14:43:46 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Pan Bian wrote: > Function lbs_cmd_802_11_sleep_params() always return 0, even if the call > to lbs_cmd_with_response() fails. In this case, the parameter @sp will > keep uninitialized. Because the return value is 0, its caller (say > lbs_sleepparams_read()) will not detect the error, and will copy the > uninitialized stack memory to user sapce, resulting in stack information > leak. To avoid the bug, this patch returns variable ret (which takes > the return value of lbs_cmd_with_response()) instead of 0. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188451 > > Signed-off-by: Pan Bian The prefix should be "libertas:", I'll fix that. -- https://patchwork.kernel.org/patch/9459597/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches