Return-path: Received: from mail-yw0-f173.google.com ([209.85.161.173]:33363 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdASNGV (ORCPT ); Thu, 19 Jan 2017 08:06:21 -0500 Received: by mail-yw0-f173.google.com with SMTP id l75so31889823ywb.0 for ; Thu, 19 Jan 2017 05:05:30 -0800 (PST) Subject: Re: [PATCH] nl80211: fix validation of scheduled scan info for wowlan netdetect To: Luca Coelho , Johannes Berg References: <1484820088-24448-1-git-send-email-arend.vanspriel@broadcom.com> <1484827206.2774.12.camel@coelho.fi> Cc: linux-wireless From: Arend Van Spriel Message-ID: (sfid-20170119_140624_769549_F97FC8DD) Date: Thu, 19 Jan 2017 14:08:44 +0100 MIME-Version: 1.0 In-Reply-To: <1484827206.2774.12.camel@coelho.fi> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 19-1-2017 13:00, Luca Coelho wrote: > On Thu, 2017-01-19 at 10:01 +0000, Arend van Spriel wrote: >> For wowlan netdetect a separate limit is defined for the number of >> matchsets. Currently, this limit is ignored and the regular limit >> for scheduled scan matchsets, ie. struct wiphy::max_match_sets, is >> used for the net-detect case as well. >> >> Cc: Luciano Coelho >> Signed-off-by: Arend van Spriel >> --- > > What?! You don't have the same number of matchsets for both? :P Actually I have, but your comment mentioned they do not have to be the same. brcmfmac actually did not set max_nd_match_sets so I was surprised it worked. That said this patch will result in regression in brcmfmac :-p Not sure about other drivers supporting net-detect. Regards, Arend > Looks good. > > Reviewed-by: Luca Coelho > > -- > Luca. >