Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:36396 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdAXSKv (ORCPT ); Tue, 24 Jan 2017 13:10:51 -0500 Received: by mail-pg0-f46.google.com with SMTP id t6so56811642pgt.3 for ; Tue, 24 Jan 2017 10:10:51 -0800 (PST) Date: Tue, 24 Jan 2017 10:10:41 -0800 From: Stephen Hemminger To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: netdev@vger.kernel.org, "David S . Miller" , Felix Fietkau , Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast Message-ID: <20170124101041.55c2ab39@xeon-e3> (sfid-20170124_191103_474938_8757A5B1) In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 21 Jan 2017 21:01:32 +0100 Linus L=C3=BCssing wrote: > @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port= _group( > hlist_add_head(&p->mglist, &port->mglist); > setup_timer(&p->timer, br_multicast_port_group_expired, > (unsigned long)p); > + > + if (src) > + memcpy(p->eth_addr, src, ETH_ALEN); > + else > + memset(p->eth_addr, 0xff, ETH_ALEN); > + > return p; > } Maybe use ether_addr_copy here, but is not performance critical