Return-path: Received: from mail-lf0-f52.google.com ([209.85.215.52]:35462 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbdB1K0z (ORCPT ); Tue, 28 Feb 2017 05:26:55 -0500 Received: by mail-lf0-f52.google.com with SMTP id z127so3528736lfa.2 for ; Tue, 28 Feb 2017 02:25:21 -0800 (PST) Subject: Re: [PATCH 4.12] brcmfmac: get rid of brcmf_txflowblock helper function To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20170227120606.15506-1-zajec5@gmail.com> <89be1d04-640e-bd59-77d9-13ddde9979bb@broadcom.com> Cc: Kalle Valo , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= From: Arend Van Spriel Message-ID: (sfid-20170228_112659_957138_3BF39228) Date: Tue, 28 Feb 2017 11:16:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 28-2-2017 11:00, Rafał Miłecki wrote: > On 28 February 2017 at 10:50, Arend Van Spriel > wrote: >> On 27-2-2017 13:06, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> This helper function is pretty trivial and we can easily do without it. >>> What's important though it's one of FWS (Firmware Signalling) >>> dependencies in core.c. The plan is to make FWS required by BCDC only so >>> we don't have to use/compile it when using msgbuf. >> >> This is the same discussion as before. Our driver design really wants to >> keep bus-specific code separated from common code. Adding more and more >> include statements is breaking that design. Whether or not that >> resembles the way other drivers do it is not really a consideration. So >> I would rather like to see patches that improve that separation. >> >> I will see if I can publish the design summary on our wiki page. > > You may not like this solution, but if so, please suggest another one. > Then we can discuss two of them & find a final one. > > As you see I'm trying to drop fws dependency from core.c. It's what > was very roughly discussed in: > brcmfmac: initialize fws(ignal) for BCDC protocol only > https://patchwork.kernel.org/patch/9349301/ > > My guess if you have another patch for this, but since you didn't > manage to release it since September, I'd really like to move things > forward somehow. Franky has taken it on his shoulders, but it seems to have slipped under the rug. Maybe he can chime in. Regards, Arend