Return-path: Received: from mail-oi0-f47.google.com ([209.85.218.47]:32931 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188AbdB1Kbq (ORCPT ); Tue, 28 Feb 2017 05:31:46 -0500 Received: by mail-oi0-f47.google.com with SMTP id 2so3746843oif.0 for ; Tue, 28 Feb 2017 02:31:46 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <89be1d04-640e-bd59-77d9-13ddde9979bb@broadcom.com> References: <20170227120606.15506-1-zajec5@gmail.com> <89be1d04-640e-bd59-77d9-13ddde9979bb@broadcom.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Date: Tue, 28 Feb 2017 11:00:45 +0100 Message-ID: (sfid-20170228_113207_869560_14B87EB7) Subject: Re: [PATCH 4.12] brcmfmac: get rid of brcmf_txflowblock helper function To: Arend Van Spriel Cc: Kalle Valo , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Franky Lin , "linux-wireless@vger.kernel.org" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 28 February 2017 at 10:50, Arend Van Spriel wrote: > On 27-2-2017 13:06, Rafa=C5=82 Mi=C5=82ecki wrote: >> From: Rafa=C5=82 Mi=C5=82ecki >> >> This helper function is pretty trivial and we can easily do without it. >> What's important though it's one of FWS (Firmware Signalling) >> dependencies in core.c. The plan is to make FWS required by BCDC only so >> we don't have to use/compile it when using msgbuf. > > This is the same discussion as before. Our driver design really wants to > keep bus-specific code separated from common code. Adding more and more > include statements is breaking that design. Whether or not that > resembles the way other drivers do it is not really a consideration. So > I would rather like to see patches that improve that separation. > > I will see if I can publish the design summary on our wiki page. You may not like this solution, but if so, please suggest another one. Then we can discuss two of them & find a final one. As you see I'm trying to drop fws dependency from core.c. It's what was very roughly discussed in: brcmfmac: initialize fws(ignal) for BCDC protocol only https://patchwork.kernel.org/patch/9349301/ My guess if you have another patch for this, but since you didn't manage to release it since September, I'd really like to move things forward somehow.