Return-path: Received: from mail-qk0-f175.google.com ([209.85.220.175]:33162 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754410AbdBPKbL (ORCPT ); Thu, 16 Feb 2017 05:31:11 -0500 Received: by mail-qk0-f175.google.com with SMTP id p22so11342790qka.0 for ; Thu, 16 Feb 2017 02:31:05 -0800 (PST) Subject: Re: drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init' To: Kalle Valo References: <201702071839.Ej9MjmlI%fengguang.wu@intel.com> <87inoamqh6.fsf@kamboji.qca.qualcomm.com> <59013c13-af43-cf9f-8e3e-14d97e48f0dd@broadcom.com> <87efyymp2q.fsf@kamboji.qca.qualcomm.com> Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Randy Dunlap , kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org From: Arend Van Spriel Message-ID: <8ff44e41-97c7-4ae5-6850-65ad407fd788@broadcom.com> (sfid-20170216_113219_583125_2C9D465F) Date: Thu, 16 Feb 2017 11:30:56 +0100 MIME-Version: 1.0 In-Reply-To: <87efyymp2q.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 16-2-2017 11:01, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 16-2-2017 10:39, Rafał Miłecki wrote: >>> On 02/16/2017 10:31 AM, Kalle Valo wrote: >>>> (Adding linux-wireless) >>>> >>>> Randy Dunlap writes: >>>> >>>>> On 02/07/17 02:02, kbuild test robot wrote: >>>>>> Hi Kalle, >>>>>> >>>>>> FYI, the error/warning still remains. >>>>>> >>>>>> tree: >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>>> master >>>>>> head: 8b1b41ee74f9712c355d66dc105bbea663ae0afd >>>>>> commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move >>>>>> under broadcom vendor directory >>>>>> date: 1 year, 3 months ago >>>>>> config: mips-allyesconfig (attached as .config) >>>>>> compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 >>>>>> reproduce: >>>>>> wget >>>>>> https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross >>>>>> >>>>>> -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> git checkout 05491d2ccf20b20a1375303441fbbfbd12b24a4f >>>>>> # save the attached .config to linux build tree >>>>>> make.cross ARCH=mips >>>>>> >>>>>> All errors (new ones prefixed by >>): > n>>>> >>>>> when both: >>>>> >>>>> CONFIG_BRCM_TRACING=y >>>>> CONFIG_BRCMDBG=y >>>>> >>>>> but DEBUG is not defined. >>>>> >>>>> I think it would help if CONFIG_BRCMDBG set DEBUG >>>>> or if some of the tests for DEBUG used CONFIG_BRCMDBG instead. >>>> >>>> Arend or Rafał, would you be able to look at this build problem? Kbuild >>>> found the build errors below, apparently a very old issue. It just >>>> blames me now because I moved the driver to a new directory :) >> >> It is a very old issue. The thing is that the issue can not really occur >> because we have this: >> >> # common flags >> subdir-ccflags-$(CONFIG_BRCMDBG) += -DDEBUG >> >> in drivers/net/wireless/broadcom/brcm80211/Makefile. So no clue what >> happens in the "kbuild test robot" scenario. > > I actually tried to reproduce this with kbuild bot's instructions and > was surprised to see that the build worked ok for me. So the issue is > not that simple. Hi Kalle, Here is the old email exchange we had about this [1]. In my opinion this is a Kbuild issue that needs to be looked into. Regards, Arend [1] http://www.spinics.net/lists/linux-wireless/msg142122.html