Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:36742 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdBOKfA (ORCPT ); Wed, 15 Feb 2017 05:35:00 -0500 Received: by mail-pg0-f46.google.com with SMTP id v184so36053201pgv.3 for ; Wed, 15 Feb 2017 02:35:00 -0800 (PST) Subject: Re: [RFC v2 3/7] ieee80211: add new VHT capability fields/parsing To: Johannes Berg , linux-wireless@vger.kernel.org References: <20170214132208.8715-1-johannes@sipsolutions.net> <20170214132208.8715-4-johannes@sipsolutions.net> <281180d5-2a7e-00b5-f12b-13bf568812da@broadcom.com> <1487150216.4026.18.camel@sipsolutions.net> <1487152112.4026.19.camel@sipsolutions.net> <1f3197b6-2860-632c-bbbb-3afac16f6edc@broadcom.com> Cc: j@w1.fi, greearb@candelatech.com From: Arend Van Spriel Message-ID: <827a5262-4a4b-d550-d5fe-fd53f3bb53db@broadcom.com> (sfid-20170215_113504_759543_B6523101) Date: Wed, 15 Feb 2017 11:34:56 +0100 MIME-Version: 1.0 In-Reply-To: <1f3197b6-2860-632c-bbbb-3afac16f6edc@broadcom.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 15-2-2017 11:34, Arend Van Spriel wrote: > On 15-2-2017 10:48, Johannes Berg wrote: >> On Wed, 2017-02-15 at 10:36 +0100, Arend Van Spriel wrote: >>> >>>> I'm not really sure what to do - we don't really want to print a >>>> message on something that might have been received from the peer, I >>>> think? Though I suppose we should return 0 for the invalid >>>> combinations, indicating that they're not supported. >>> >>> Ah. This is all non-functional code yet, right? At least having a >>> static non-inline function in ieee80211.h will give build issues I >>> would think. >> >> No, I marked it __maybe_unused so it'll be fine. I didn't want to have >> it inlined if you use it multiple times in a single source file, but I >> didn't want to move it to somewhere else either ... > > Ah. Now I understand the trickery ;-) Was there really no "somewhere > else" to move it, because honestly it is confusing and a bit wasteful if > used multiple times in cfg80211 and/or drivers. Although exporting it also comes at a cost. Gr. AvS > Gr. AvS > >>> Anyway, I would indeed return 0 and have caller deal with that. >> >> Yeah, I'll do that. >> >> johannes >>