Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753651AbdBGQ7P (ORCPT ); Tue, 7 Feb 2017 11:59:15 -0500 From: Paolo Abeni To: Kalle Valo Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, Arend van Spriel , Franky Lin , hante Meuleman Subject: [PATCH net] brcmfmac: clear skb head state on xmit Date: Tue, 7 Feb 2017 17:50:36 +0100 Message-Id: (sfid-20170207_175919_375794_98298A73) Sender: linux-wireless-owner@vger.kernel.org List-ID: the skbs can be held by the driver for a long time, so we need to clear any state on xmit to avoid hanging other subsystems. The skbs are already orphaned later in cmsg code, so we just need to clear the nf/dst/secpath. Do it early, while the relevant entries are hopefully still hot in the cache. Signed-off-by: Paolo Abeni --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 9e6f60a..5a8d57b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include @@ -243,6 +244,13 @@ static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb, if ((skb->priority == 0) || (skb->priority > 7)) skb->priority = cfg80211_classify8021d(skb, NULL); + /* we can keep the skb for a long time; avoid starving other + * subsystems + */ + nf_reset(skb); + skb_dst_drop(skb); + secpath_reset(skb); + ret = brcmf_proto_tx_queue_data(drvr, ifp->ifidx, skb); if (ret < 0) brcmf_txfinalize(ifp, skb, false); -- 2.9.3