Return-path: Received: from mail-wr0-f181.google.com ([209.85.128.181]:35342 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbdBULeu (ORCPT ); Tue, 21 Feb 2017 06:34:50 -0500 Received: by mail-wr0-f181.google.com with SMTP id s27so33368219wrb.2 for ; Tue, 21 Feb 2017 03:34:49 -0800 (PST) Subject: Re: [PATCH] cfg80211: support 4-way handshake offloading for WPA/WPA2-PSK To: Johannes Berg , linux-wireless@vger.kernel.org References: <20170221100957.30965-1-johannes@sipsolutions.net> <231f969e-eac1-3196-07c2-80e37e6dda55@broadcom.com> <1487673603.2215.3.camel@sipsolutions.net> Cc: Eliad Peller From: Arend Van Spriel Message-ID: (sfid-20170221_123453_534938_077175CC) Date: Tue, 21 Feb 2017 12:34:46 +0100 MIME-Version: 1.0 In-Reply-To: <1487673603.2215.3.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 21-2-2017 11:40, Johannes Berg wrote: > On Tue, 2017-02-21 at 11:32 +0100, Arend Van Spriel wrote: >> On 21-2-2017 11:09, Johannes Berg wrote: >>> From: Eliad Peller >>> >>> Let drivers advertise support for station-mode 4-way handshake >>> offloading with a new >>> NL80211_EXT_FEATURE_4WAY_HANDSHAKE_OFFLOAD_STA >>> flag. >> >> I find use of the term OFFLOAD a bit redundant as it is implied by >> its presence anyway. > > Fair enough, we can remove that. > >>> Add a new NL80211_ATTR_PMK attribute that might be passed as part >>> of NL80211_CMD_CONNECT command, and contain the PSK (which is the >>> PMK, hence the name.) It is also added to NL80211_CMD_ASSOCIATE. Maybe worth mentioning. >>> The driver/device is assumed to handle the 4-way handshake by >>> itself in this case (including key derivations, etc.), instead >>> of relying on the supplicant. What I am also missing is how to deal with NL80211_CMD_CONNECTED event signalling. Should that be given after (un)successful completion of the 4-way handshake or should we have a separate event for that? Regards, Arend >>> This patch is somewhat based on this one (by Vladimir Kondratiev): >>> https://patchwork.kernel.org/patch/1309561/. >> >> It also looks quite like this one we posted a while ago [1]. Our bad >> that we did not follow-up :-p > > Indeed, I was looking for the better link (had gmane recorded in the > internal commit log) and found a few that all looked the same ... :) > > Would this work for you? We should have wpa_supplicant support too, but > need to ask Andrei to look at that. > > johannes >