Return-path: Received: from mga06.intel.com ([134.134.136.31]:28143 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbdCZMhG (ORCPT ); Sun, 26 Mar 2017 08:37:06 -0400 Message-ID: <1490531821.708.7.camel@linux.intel.com> (sfid-20170326_143732_392746_B8D5EFA0) Subject: Re: [PATCH v1] NFC: Add nfc_dbg() macro From: Andy Shevchenko To: Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , linux-wireless@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org Date: Sun, 26 Mar 2017 15:37:01 +0300 In-Reply-To: <20170322192251.30261-1-andriy.shevchenko@linux.intel.com> References: <20170322192251.30261-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2017-03-22 at 21:22 +0200, Andy Shevchenko wrote: > In some cases nfc_dbg() is useful. Add such macro to a header. > I think we may drop this, since the idea is to get rid of such macros (as I read back in 2011 in commit message of change that removed nfc_dbg() one). I will re-do dependent series to not use it at all. > Signed-off-by: Andy Shevchenko > --- >  include/net/nfc/nfc.h | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/include/net/nfc/nfc.h b/include/net/nfc/nfc.h > index 1a3de8b34ad2..bbdc73a3239d 100644 > --- a/include/net/nfc/nfc.h > +++ b/include/net/nfc/nfc.h > @@ -27,6 +27,7 @@ >  #include >  #include >   > +#define nfc_dbg(dev, fmt, ...) dev_dbg((dev), "NFC: " fmt, > ##__VA_ARGS__) >  #define nfc_info(dev, fmt, ...) dev_info((dev), "NFC: " fmt, > ##__VA_ARGS__) >  #define nfc_err(dev, fmt, ...) dev_err((dev), "NFC: " fmt, > ##__VA_ARGS__) >   -- Andy Shevchenko Intel Finland Oy