Return-path: Received: from mail-wr0-f172.google.com ([209.85.128.172]:34566 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751230AbdCGK1Y (ORCPT ); Tue, 7 Mar 2017 05:27:24 -0500 Received: by mail-wr0-f172.google.com with SMTP id l37so135795803wrc.1 for ; Tue, 07 Mar 2017 02:25:44 -0800 (PST) Subject: Re: [PATCH v2 1/4] brcmfmac: Do not print the firmware version as an error To: Hans de Goede , Franky Lin , Hante Meuleman , Kalle Valo References: <20170227214539.16422-1-hdegoede@redhat.com> Cc: Takashi Iwai , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com From: Arend Van Spriel Message-ID: <5f6bb4d4-1bf1-cd5b-96ba-fc45e641aa95@broadcom.com> (sfid-20170307_112747_222259_79CC2731) Date: Tue, 7 Mar 2017 10:59:08 +0100 MIME-Version: 1.0 In-Reply-To: <20170227214539.16422-1-hdegoede@redhat.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 27-2-2017 22:45, Hans de Goede wrote: > Using pr_err for things which are not errors is a bad idea. E.g. it > will cause the plymouth bootsplash screen to drop back to the text > console so that the user can see the error, which is not what we > normally want to happen. > > Instead add a new brcmf_info macro and use that. > > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Fix brcm_err typo (should be brcmf_err) in CONFIG_BRCM_TRACING case > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 +- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c > index 3e15d64..6d565f1 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c > @@ -161,7 +161,7 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp) > strsep(&ptr, "\n"); > > /* Print fw version info */ > - brcmf_err("Firmware version = %s\n", buf); > + brcmf_info("Firmware version = %s\n", buf); > > /* locate firmware version number for ethtool */ > ptr = strrchr(buf, ' ') + 1; > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > index 6687812..605f260 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h > @@ -59,11 +59,14 @@ > pr_err("%s: " fmt, __func__, ##__VA_ARGS__); \ > } while (0) > #endif > +#define brcmf_info(fmt, ...) pr_info("%s: " fmt, __func__, ##__VA_ARGS__) Prefer using the same style as for brcmf_err, ie. using do {} while (0) Regards, Arend > #else > __printf(2, 3) > void __brcmf_err(const char *func, const char *fmt, ...); > #define brcmf_err(fmt, ...) \ > __brcmf_err(__func__, fmt, ##__VA_ARGS__) > +/* For tracing purposes treat info messages as errors */ > +#define brcmf_info brcmf_err > #endif > > #if defined(DEBUG) || defined(CONFIG_BRCM_TRACING) >