Return-path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:34164 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180AbdCGKFB (ORCPT ); Tue, 7 Mar 2017 05:05:01 -0500 Received: by mail-wm0-f51.google.com with SMTP id 196so23264783wmm.1 for ; Tue, 07 Mar 2017 02:04:48 -0800 (PST) Subject: Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size To: Kalle Valo , Arnd Bergmann References: <20170302163834.2273519-1-arnd@arndb.de> <20170302163834.2273519-9-arnd@arndb.de> <227c8e5a-fa20-0300-1cb0-1d3ef17deb19@broadcom.com> <87y3wi74y8.fsf@purkki.adurom.net> <877f414e1n.fsf@codeaurora.org> Cc: kasan-dev , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Networking , Linux Kernel Mailing List , linux-media@vger.kernel.org, linux-wireless , kernel-build-reports@lists.linaro.org, "David S . Miller" From: Arend Van Spriel Message-ID: <2e8b7c30-41d5-b605-d502-6b914507e4e1@broadcom.com> (sfid-20170307_110626_284456_17EB5DD9) Date: Tue, 7 Mar 2017 10:55:36 +0100 MIME-Version: 1.0 In-Reply-To: <877f414e1n.fsf@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 7-3-2017 10:44, Kalle Valo wrote: > Arnd Bergmann writes: > >> On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> >>>> On 2-3-2017 17:38, Arnd Bergmann wrote: >>>>> With KASAN and a couple of other patches applied, this driver is one >>>>> of the few remaining ones that actually use more than 2048 bytes of >>>>> kernel stack: >>>>> >>>>> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function >>>>> 'wlc_phy_workarounds_nphy_gainctrl': >>>>> broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the >>>>> frame size of 3264 bytes is larger than 2048 bytes >>>>> [-Wframe-larger-than=] >>>>> broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy': >>>>> broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the >>>>> frame size of 2864 bytes is larger than 2048 bytes >>>>> [-Wframe-larger-than=] >>>>> >>>>> Here, I'm reducing the stack size by marking as many local variables as >>>>> 'static const' as I can without changing the actual code. >>>> >>>> Acked-by: Arend van Spriel >>> >>> Arnd, via which tree are you planning to submit these? I'm not sure >>> what I should do with the wireless drivers patches from this series. >> >> I'm not quite sure myself yet. I'd probably want the first few patches that >> do most of the work get merged through Andrew's linux-mm tree once >> we have come to agreement on them. The driver specific patches like >> the brcmsmac ones depend on the introduction of noinline_for_kasan >> or noinline_if_stackbloat and could either go in along with the first >> set, or as a follow-up through the normal maintainer trees. > > Either way is fine for me. Just mark clearly if you want the wireless > drivers patches to go through via my tree, otherwise I'll ignore them. That (dreaded) phy code does not get a lot of changes so I think it does not matter which tree is will go through in terms of risk for conflicts. So going through linux-mm is fine for me as well. Regards, Arend