Return-path: Received: from mail-yw0-f193.google.com ([209.85.161.193]:33498 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbdDFSgT (ORCPT ); Thu, 6 Apr 2017 14:36:19 -0400 Received: by mail-yw0-f193.google.com with SMTP id p77so3431771ywg.0 for ; Thu, 06 Apr 2017 11:36:19 -0700 (PDT) From: Jes Sorensen Subject: Re: [PATCH] staging: Add rtl8723bs sdio wifi driver To: Larry Finger , Hans de Goede , Bastien Nocera , Arend Van Spriel References: <20170329174751.13184-1-hdegoede@redhat.com> <4d1d3c02-eff6-0410-cee0-9360ec645e13@lwfinger.net> <049673a4-647b-a270-bb9c-15bb2ab49fc4@redhat.com> <560981e0-e1b0-7a06-80e4-14d677c7d64a@redhat.com> <15871468-0086-2d66-328b-0699ef6f4b31@lwfinger.net> <5d15c6e8-7c15-4226-c4be-d8db6ded29ef@redhat.com> <1491469492.10783.7.camel@hadess.net> <26ba192c-c942-06e2-941f-c5f6ab05d146@redhat.com> <5880f060-f682-a2ce-3528-faa389f1738a@lwfinger.net> Cc: linux-wireless@vger.kernel.org Message-ID: (sfid-20170406_203623_690325_9C0611E8) Date: Thu, 6 Apr 2017 14:36:17 -0400 MIME-Version: 1.0 In-Reply-To: <5880f060-f682-a2ce-3528-faa389f1738a@lwfinger.net> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/06/2017 02:32 PM, Larry Finger wrote: > On 04/06/2017 04:49 AM, Hans de Goede wrote: >> Hi, >> >> On 06-04-17 11:04, Bastien Nocera wrote: >>> On Thu, 2017-04-06 at 08:55 +0200, Hans de Goede wrote: >>>> >>> >>>> Good thank you. So what is the plan with the github version ? >>>> >>>> Note that my submission contains a few small fixes on top of >>>> the github version, for which I intended to submit a pull-req >>>> but I've not gotten around to that yet, I've done so now: >>>> >>>> https://github.com/hadess/rtl8723bs/pull/125 >>>> >>>> But do we want to keep maintaining the github version (for a while >>>> at least) I wonder, as that does mean double work? >>> >>> My plan is to remove everything and point to the upstream tree as soon >>> as the support has landed in Linus' tree. >>> >>> While there is some use in keeping it around for older kernels, we keep >>> getting asked to support even older kernels than reasonable, or have >>> users complaining about non-working machines once they use the driver, >>> which simply uncovers kernel bugs that were fixed upstream. >>> >>> I don't think it's a good use of our time to carry on supporting this >>> out-of-tree. I'll however make sure to try and document the migration >>> in a way that's helpful to users. >> >> Ok, that works for me. > > I agree. I have enough to do. You could simply break the build, and have it spit out a warning saying the git repo is kept there to track the old source. It might be useful to have a repository of the original code to go look at. Cheers, Jes